linux-kernel - Re: [PATCH] HID: asus: Add missing Fn key maps on ASUS E200H

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1703301117560.31814@cbobk.fhfr.pm>
Date:   Thu, 30 Mar 2017 11:19:21 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Takashi Iwai <tiwai@...e.de>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Matjaz Hegedic <matjaz.hegedic@...il.com>
Subject: Re: [PATCH] HID: asus: Add missing Fn key maps on ASUS E200H

On Mon, 27 Mar 2017, Takashi Iwai wrote:

> The mapping of a few Fn combo keys seems missing since they are vendor
> specific usage page (0xff31).  Add the mapping manually for sleep
> (Fn-F1), rfkill (Fn-F2), brightness down (Fn-F5), brightness up
> (Fn-F6), display toggle (Fn-F7), and touchpad toggle (Fn-F9).
> For the display toggle and the touchpad toggle, KEY_SCREENLOCK and
> KEY_F21 are assigned as convention.
> 
> The monitor switch (Fn-F8), and audio volume down / up /mute (Fn-F10,
> F11, F12) work as is without the extra mapping, thus left as is.
> 
> Signed-off-by: Takashi Iwai <tiwai@...e.de>

I think is has already been covered by Matjaz's (adding to CC) patches in 
hid.git#for-4.12/asus. Could you please check whether it covers everything 
your patch did?

Thanks,

-- 
Jiri Kosina
SUSE Labs