linux-kernel - Re: [PATCH v6 07/11] drivers: perf: hisi: Add support for Hisilicon SoC event counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58DCD47C.2010501@gmail.com>
Date:   Thu, 30 Mar 2017 15:18:44 +0530
From:   Anurup M <anurupvasu@...il.com>
To:     Mark Rutland <mark.rutland@....com>
Cc:     will.deacon@....com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, anurup.m@...wei.com,
        zhangshaokun@...ilicon.com, tanxiaojun@...wei.com,
        xuwei5@...ilicon.com, sanil.kumar@...ilicon.com,
        john.garry@...wei.com, gabriele.paoloni@...wei.com,
        shiju.jose@...wei.com, huangdaode@...ilicon.com,
        linuxarm@...wei.com, dikshit.n@...wei.com, shyju.pv@...wei.com
Subject: Re: [PATCH v6 07/11] drivers: perf: hisi: Add support for Hisilicon
 SoC event counters



On Tuesday 21 March 2017 10:22 PM, Mark Rutland wrote:
> +static int hisi_hw_perf_event_init(struct perf_event *event)
> >+{
> >+	struct hw_perf_event *hwc = &event->hw;
> >+	struct hisi_pmu *hisi_pmu = to_hisi_pmu(event->pmu);
> >+	struct device *dev = hisi_pmu->dev;
>> +
>> >+	/*
>> >+	 * We must NOT create groups containing mixed PMUs, although
>> >+	 * software events are acceptable
>> >+	 */
>> >+	if (event->group_leader->pmu != event->pmu &&
>> >+	    !is_software_event(event->group_leader))
>> >+		return -EINVAL;
>> >+
>> >+	list_for_each_entry(sibling, &event->group_leader->sibling_list,
>> >+			    group_entry)
>> >+		if (sibling->pmu != event->pmu && !is_software_event(sibling))
>> >+			return -EINVAL;
> Please also check the number of counters.

Sorry, I could not follow this comment correctly. Could you please explain ?
I check the available counters and update used mask in pmu_add --> 
get_event_index

Thanks,
Anurup

> [...]
>