linux-kernel - Re: [PATCH 1/2] staging: atomisp: simplify the if condition in atomisp_freq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1490871164.4738.0.camel@linux.intel.com>
Date:   Thu, 30 Mar 2017 11:52:44 +0100
From:   Alan Cox <alan@...ux.intel.com>
To:     Daeseok Youn <daeseok.youn@...il.com>, mchehab@...nel.org
Cc:     gregkh@...uxfoundation.org, dan.carpenter@...cle.com,
        singhalsimran0@...il.com, linux-media@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: atomisp: simplify the if condition in
 atomisp_freq_scaling()

On Thu, 2017-03-30 at 15:24 +0900, Daeseok Youn wrote:
> The condition line in if-statement is needed to be shorthen to
> improve readability.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---

How about a define for ATOMISP_IS_CHT(isp) instead - as we will need
these tests in other places where there are ISP2400/ISP2401 ifdefs ?

Alan