linux-kernel - Re: [PATCH v2 1/2] usb: phy: Introduce one extcon device into usb phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMz4kuLPPD3ZbdrQ7=NyPSDgJZ-9xfFu3wQ57gQVro1WC1nebw@mail.gmail.com>
Date:   Thu, 30 Mar 2017 10:56:07 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Felipe Balbi <balbi@...nel.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        USB <linux-usb@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linaro Kernel Mailman List <linaro-kernel@...ts.linaro.org>,
        NeilBrown <neilb@...e.com>, Jun Li <jun.li@....com>,
        Peter Chen <peter.chen@...escale.com>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v2 1/2] usb: phy: Introduce one extcon device into usb phy

Hi,

On 28 March 2017 at 21:40, Felipe Balbi <balbi@...nel.org> wrote:
>
> Hi,
>
> Baolin Wang <baolin.wang@...aro.org> writes:
>> Usually usb phy need register one extcon device to get the connection
>> notifications. It will remove some duplicate code if the extcon device
>> is registered using common code instead of each phy driver having its
>> own related extcon APIs. So we add one pointer of extcon device into
>> usb phy structure, and some other helper functions to register extcon.
>>
>> Suggested-by: NeilBrown <neilb@...e.com>
>> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
>
> will this work with devices which have ID and VBUS from separate EXTCON
> devices?

Ah, It can not work for separate EXTCON devices, now I realized some
devices have separate EXTCON devices. Thanks for pointing this.

-- 
Baolin.wang
Best Regards