linux-kernel - Re: [RESEND PATCH v2 1/2] mfd: retu: Add OF device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJTxT1V1Y8Wte4W22UjFcAKUuny5VCFpurwjkPz=hGxVQ@mail.gmail.com>
Date:   Thu, 30 Mar 2017 07:41:13 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [RESEND PATCH v2 1/2] mfd: retu: Add OF device ID table

On Wed, Mar 15, 2017 at 5:49 AM, Javier Martinez Canillas
<javier@....samsung.com> wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.

It should also have the OF MODALIAS.

> But this could change in the future so the correct approach is to have a
> OF device ID table if the devices are registered via OF.

I believe this is already the case.

> The compatible strings don't have a vendor prefix because that's how it's
> used currently, and changing this will be a Device Tree ABI break.

How so? These "compatible" strings are not documented, so there is no
ABI. You may have been lucky to get things working using the driver
name as the compatible string.

Rob