lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Mar 2017 16:30:52 +0100 From: Salil Mehta <salil.mehta@...wei.com> To: <davem@...emloft.net> CC: <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>, <mehta.salil.lnk@...il.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>, lipeng <lipeng321@...wei.com>, Weiwei Deng <dengweiwei@...wei.com> Subject: [PATCH net 05/19] net: hns: Remove redundant memset during buffer release From: lipeng <lipeng321@...wei.com> Because all members of desc_cb is assigned when xmit one package, so it can delete in hnae_free_buffer, as follows: - "dma, priv, length, type" are assigned in fill_v2_desc. - "page_offset, reuse_flag, buf" are not used in tx direction. Signed-off-by: lipeng <lipeng321@...wei.com> Signed-off-by: Weiwei Deng <dengweiwei@...wei.com> Reviewed-by: Yisen Zhuang <yisen.zhuang@...wei.com> Signed-off-by: Salil Mehta <salil.mehta@...wei.com> --- drivers/net/ethernet/hisilicon/hns/hnae.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/drivers/net/ethernet/hisilicon/hns/hnae.c index b6ed818..78af663 100644 --- a/drivers/net/ethernet/hisilicon/hns/hnae.c +++ b/drivers/net/ethernet/hisilicon/hns/hnae.c @@ -61,7 +61,6 @@ static void hnae_free_buffer(struct hnae_ring *ring, struct hnae_desc_cb *cb) dev_kfree_skb_any((struct sk_buff *)cb->priv); else if (unlikely(is_rx_ring(ring))) put_page((struct page *)cb->priv); - memset(cb, 0, sizeof(*cb)); } static int hnae_map_buffer(struct hnae_ring *ring, struct hnae_desc_cb *cb) -- 2.7.4
Powered by blists - more mailing lists