linux-kernel - Re: [PATCH] mmc: host: s3cmci: fix broken conditional expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFq6U9mXVz-msN4uDwDJANZqdVwcKTLVyqu1rthhsRx6KQ@mail.gmail.com>
Date:   Thu, 30 Mar 2017 21:31:26 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Ben Dooks <ben-linux@...ff.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Sergio Prado <sergio.prado@...abworks.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: host: s3cmci: fix broken conditional expression

On 29 March 2017 at 11:52, Arnd Bergmann <arnd@...db.de> wrote:
> The DT support introduced a typo that gcc detects when -Wempty-body
> is enabled:
>
> drivers/mmc/host/s3cmci.c: In function 's3cmci_probe_pdata':
> drivers/mmc/host/s3cmci.c:1543:29: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
>   if (pdata->wprotect_invert);
>
> Clearly the ';' was not intended here, so remove it.
>
> Fixes: 4b13f3b290d1 ("mmc: host: s3cmci: allow probing from device tree")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/s3cmci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
> index 09eab2120bbd..bbf1fbbc8e2a 100644
> --- a/drivers/mmc/host/s3cmci.c
> +++ b/drivers/mmc/host/s3cmci.c
> @@ -1540,7 +1540,7 @@ static int s3cmci_probe_pdata(struct s3cmci_host *host)
>         if (pdata->no_detect)
>                 mmc->caps |= MMC_CAP_NEEDS_POLL;
>
> -       if (pdata->wprotect_invert);
> +       if (pdata->wprotect_invert)
>                 mmc->caps2 |= MMC_CAP2_RO_ACTIVE_HIGH;
>
>         if (pdata->detect_invert)
> --
> 2.9.0
>