linux-kernel - Re: [PATCH 1/6] mm: get rid of zone_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 Mar 2017 08:48:21 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Hillf Danton <hillf.zj@...baba-inc.com>
Cc:     linux-mm@...ck.org, 'Andrew Morton' <akpm@...ux-foundation.org>,
        'Mel Gorman' <mgorman@...e.de>,
        'Vlastimil Babka' <vbabka@...e.cz>,
        'Andrea Arcangeli' <aarcange@...hat.com>,
        'Reza Arbab' <arbab@...ux.vnet.ibm.com>,
        'Yasuaki Ishimatsu' <yasu.isimatu@...il.com>,
        'Tang Chen' <tangchen@...fujitsu.com>, qiuxishi@...wei.com,
        'Kani Toshimitsu' <toshi.kani@....com>, slaoub@...il.com,
        'Joonsoo Kim' <js1304@...il.com>,
        'Andi Kleen' <ak@...ux.intel.com>,
        'Zhang Zhen' <zhenzhang.zhang@...wei.com>,
        'David Rientjes' <rientjes@...gle.com>,
        'Daniel Kiper' <daniel.kiper@...cle.com>,
        'Igor Mammedov' <imammedo@...hat.com>,
        'Vitaly Kuznetsov' <vkuznets@...hat.com>,
        'LKML' <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/6] mm: get rid of zone_is_initialized

On Fri 31-03-17 08:43:01, Michal Hocko wrote:
> On Fri 31-03-17 11:39:07, Hillf Danton wrote:
> > 
> > On March 30, 2017 7:55 PM Michal Hocko wrote:
> > > 
> > > @@ -5535,9 +5535,6 @@ int __meminit init_currently_empty_zone(struct zone *zone,
> > >  			zone_start_pfn, (zone_start_pfn + size));
> > > 
> > >  	zone_init_free_lists(zone);
> > > -	zone->initialized = 1;
> > > -
> > > -	return 0;
> > >  }
> > Nit: Add changes more than correct.
> 
> I am sorry, I do not follow?

OK, got it. init_currently_empty_zone should be changed to void. Screw
up during the split of the initial patch. Will fix that up. Also
zone_spans_range should go to patch 5 because it doesn't have any user
until then.
-- 
Michal Hocko
SUSE Labs