lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 31 Mar 2017 09:18:05 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Hillf Danton <hillf.zj@...baba-inc.com>
Cc:     linux-mm@...ck.org, 'Andrew Morton' <akpm@...ux-foundation.org>,
        'Mel Gorman' <mgorman@...e.de>,
        'Vlastimil Babka' <vbabka@...e.cz>,
        'Andrea Arcangeli' <aarcange@...hat.com>,
        'Reza Arbab' <arbab@...ux.vnet.ibm.com>,
        'Yasuaki Ishimatsu' <yasu.isimatu@...il.com>,
        'Tang Chen' <tangchen@...fujitsu.com>, qiuxishi@...wei.com,
        'Kani Toshimitsu' <toshi.kani@....com>, slaoub@...il.com,
        'Joonsoo Kim' <js1304@...il.com>,
        'Andi Kleen' <ak@...ux.intel.com>,
        'Zhang Zhen' <zhenzhang.zhang@...wei.com>,
        'David Rientjes' <rientjes@...gle.com>,
        'Daniel Kiper' <daniel.kiper@...cle.com>,
        'Igor Mammedov' <imammedo@...hat.com>,
        'Vitaly Kuznetsov' <vkuznets@...hat.com>,
        'LKML' <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/6] mm: remove return value from
 init_currently_empty_zone

On Fri 31-03-17 15:06:41, Hillf Danton wrote:
> On March 31, 2017 2:49 PM Michal Hocko wrote: 
> > On Fri 31-03-17 11:49:49, Hillf Danton wrote:
> > [...]
> > > > -/* Can fail with -ENOMEM from allocating a wait table with vmalloc() or
> > > > - * alloc_bootmem_node_nopanic()/memblock_virt_alloc_node_nopanic() */
> > > > -static int __ref ensure_zone_is_initialized(struct zone *zone,
> > > > +static void __ref ensure_zone_is_initialized(struct zone *zone,
> > > >  			unsigned long start_pfn, unsigned long num_pages)
> > > >  {
> > > > -	if (zone_is_empty(zone))
> > > > -		return init_currently_empty_zone(zone, start_pfn, num_pages);
> > > > -
> > > > -	return 0;
> > > > +	if (!zone_is_empty(zone))
> > > > +		init_currently_empty_zone(zone, start_pfn, num_pages);
> > > >  }
> > > Semantic change added?
> > 
> > could you be more specific?
> 
> Well, I'm wondering why you are trying to initiate a nonempty zone.

Ups, another fuck up during the initial patch split up. Thanks for
catching that but it would be more helpful to be more specific during
the feedback. I am getting blind to the code I am staring for quite some
time so it was not obvious what you mean here.

Thanks
-- 
Michal Hocko
SUSE Labs

Powered by blists - more mailing lists