linux-kernel - Re: [tip:WIP.x86/mm 1/1] arch/x86/kernel/process_64.c:541:35: error: '__NR_ia32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 31 Mar 2017 13:08:13 +0300
From:   Dmitry Safonov <dsafonov@...tuozzo.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     kbuild test robot <fengguang.wu@...el.com>, <kbuild-all@...org>,
        <linux-kernel@...r.kernel.org>, <tipbuild@...or.com>
Subject: Re: [tip:WIP.x86/mm 1/1] arch/x86/kernel/process_64.c:541:35: error:
 '__NR_ia32_execve' undeclared

On 03/31/2017 10:25 AM, Thomas Gleixner wrote:
> On Thu, 30 Mar 2017, Dmitry Safonov wrote:
>>> vim +/__NR_ia32_execve +541 arch/x86/kernel/process_64.c
>>>
>>>    535		set_thread_flag(TIF_IA32);
>>>    536		clear_thread_flag(TIF_X32);
>>>    537		if (current->mm)
>>>    538			current->mm->context.ia32_compat = TIF_IA32;
>>>    539		current->personality |= force_personality32;
>>>    540		/* Prepare the first "return" to user space */
>>>  > 541		task_pt_regs(current)->orig_ax = __NR_ia32_execve;
>>>    542		current->thread.status |= TS_COMPAT;
>>>    543	#endif
>>>    544	}
>>
>> There was this chunk in the patch, maybe it could be done nicer,
>> but I didn't find the nicer way.
>> I checked it compilation/work with(out) ia32/x32/64-bit configs
>> before sending.
>
> Yeah, I know and it's just crap. WTF is wrong with:

Oh, here it is the nicer way.
I've forgot that `git grep` doesn't look into generated files.

> #ifdef CONFIG_IA32_EMULATION
> #include <asm/unistd_32_ia32.h>
> #endif
>
> It's not rocket science, really.

Sorry about that, I'll resend.


-- 
              Dmitry