lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Mar 2017 12:20:28 +0100 From: Salil Mehta <salil.mehta@...wei.com> To: <davem@...emloft.net> CC: <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>, <mehta.salil.lnk@...il.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>, Kejian Yan <yankejian@...wei.com> Subject: [PATCH V2 net-next 14/18] net: hns: Optimise the code in hns_mdio_wait_ready() From: Kejian Yan <yankejian@...wei.com> This patch fixes the code to clear pclint warning/info. Reported-by: Ping Zhang <zhangping5@...wei.com> Signed-off-by: Kejian Yan <yankejian@...wei.com> Reviewed-by: Salil Mehta <salil.mehta@...wei.com> Signed-off-by: Salil Mehta <salil.mehta@...wei.com> --- drivers/net/ethernet/hisilicon/hns_mdio.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c index fad1c5b..e5221d9 100644 --- a/drivers/net/ethernet/hisilicon/hns_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c @@ -175,18 +175,20 @@ static int mdio_sc_cfg_reg_write(struct hns_mdio_device *mdio_dev, static int hns_mdio_wait_ready(struct mii_bus *bus) { struct hns_mdio_device *mdio_dev = bus->priv; + u32 cmd_reg_value; int i; - u32 cmd_reg_value = 1; /* waitting for MDIO_COMMAND_REG 's mdio_start==0 */ /* after that can do read or write*/ - for (i = 0; cmd_reg_value; i++) { + for (i = 0; i < MDIO_TIMEOUT; i++) { cmd_reg_value = MDIO_GET_REG_BIT(mdio_dev, MDIO_COMMAND_REG, MDIO_CMD_START_B); - if (i == MDIO_TIMEOUT) - return -ETIMEDOUT; + if (!cmd_reg_value) + break; } + if ((i == MDIO_TIMEOUT) && cmd_reg_value) + return -ETIMEDOUT; return 0; } -- 2.7.4
Powered by blists - more mailing lists