linux-kernel - Re: [PATCH 1/2] kvm: make KVM_CAP_COALESCED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170331134106.GC6019@potion>
Date:   Fri, 31 Mar 2017 15:41:07 +0200
From:   Radim Krčmář <rkrcmar@...hat.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        lei.cao@...atus.com
Subject: Re: [PATCH 1/2] kvm: make KVM_CAP_COALESCED_MMIO architecture
 agnostic

2017-03-31 13:53+0200, Paolo Bonzini:
> Remove code from architecture files that can be moved to virt/kvm, since there
> is already common code for coalesced MMIO.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> @@ -2919,6 +2919,11 @@ static long kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
> +#ifdef KVM_COALESCED_MMIO_PAGE_OFFSET
> +	case KVM_CAP_COALESCED_MMIO:
> +		return KVM_COALESCED_MMIO_PAGE_OFFSET;
> +		break;

This 'break;' is pointless and would be best removed when applying,
thanks.

> +#endif