linux-kernel - Re: [PATCH v5 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc660ca0-b068-ef12-b422-d7c1672b7c41@baylibre.com>
Date:   Fri, 31 Mar 2017 15:45:38 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Hans Verkuil <hverkuil@...all.nl>, dri-devel@...ts.freedesktop.org,
        laurent.pinchart+renesas@...asonboard.com, architt@...eaurora.org,
        mchehab@...nel.org
Cc:     Jose.Abreu@...opsys.com, kieran.bingham@...asonboard.com,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-media@...r.kernel.org,
        hans.verkuil@...co.com, sakari.ailus@...ux.intel.com
Subject: Re: [PATCH v5 3/6] documentation: media: Add documentation for new
 RGB and YUV bus formats

On 03/31/2017 03:14 PM, Hans Verkuil wrote:
> On 30/03/17 11:04, Neil Armstrong wrote:
>> Add documentation for added Bus Formats to describe RGB and YUV formats used
>> as input to the Synopsys DesignWare HDMI TX Controller.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
>> ---
>>  Documentation/media/uapi/v4l/subdev-formats.rst | 871 +++++++++++++++++++++++-
>>  1 file changed, 857 insertions(+), 14 deletions(-)
> 
> This looks good, but the "Packed YUV Formats" documentation should be updated.
> 
> Currently this says:
> 
> -  The number of bus samples per pixel. Pixels that are wider than the
>    bus width must be transferred in multiple samples. Common values are
>    1, 1.5 (encoded as 1_5) and 2.
> 
> I propose this change:
> 
> -  The number of bus samples per pixel. Pixels that are wider than the
>    bus width must be transferred in multiple samples. Common values are
>    0.5 (encoded as 0_5; in this case two pixels are transferred per bus
>    sample), 1, 1.5 (encoded as 1_5) and 2.
> 
> With that additional change you can add my:
> 
> Acked-by: Hans Verkuil <hans.verkuil@...co.com>
> 
> Regards,
> 
> 	Hans
> 

Hi Hans,

Thanks for the hint, I will change this and post a v5.1 with your acks.

Neil