lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Mar 2017 17:30:45 +0200 From: Juergen Gross <jgross@...e.com> To: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> Cc: linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org, boris.ostrovsky@...cle.com Subject: Re: [PATCH v2] xen: make functions in xen-acpi-processor return void On 31/03/17 17:15, Konrad Rzeszutek Wilk wrote: > On Fri, Mar 31, 2017 at 04:40:56PM +0200, Juergen Gross wrote: >> There are several functions in xen-acpi-processor which either always >> return the same value or where the returned value is never checked. >> >> Make the functions return void. > > Well, we could actually check it and do some extra error reporting? > (Does it even make sense?) > > Granted the code was done this way so that if we did fail - we would > try to continue on instead of giving up. > > Perhaps you can include that in the commit description? Thanks Okay. I'll change the commit description. Juergen
Powered by blists - more mailing lists