linux-kernel - Re: [PATCH 3/6] mm: remove return value from init_currently_empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04ad01d2a9d1$d99b0540$8cd10fc0$@alibaba-inc.com>
Date:   Fri, 31 Mar 2017 11:49:49 +0800
From:   "Hillf Danton" <hillf.zj@...baba-inc.com>
To:     "'Michal Hocko'" <mhocko@...nel.org>, <linux-mm@...ck.org>
Cc:     "'Andrew Morton'" <akpm@...ux-foundation.org>,
        "'Mel Gorman'" <mgorman@...e.de>,
        "'Vlastimil Babka'" <vbabka@...e.cz>,
        "'Andrea Arcangeli'" <aarcange@...hat.com>,
        "'Reza Arbab'" <arbab@...ux.vnet.ibm.com>,
        "'Yasuaki Ishimatsu'" <yasu.isimatu@...il.com>,
        "'Tang Chen'" <tangchen@...fujitsu.com>, <qiuxishi@...wei.com>,
        "'Kani Toshimitsu'" <toshi.kani@....com>, <slaoub@...il.com>,
        "'Joonsoo Kim'" <js1304@...il.com>,
        "'Andi Kleen'" <ak@...ux.intel.com>,
        "'Zhang Zhen'" <zhenzhang.zhang@...wei.com>,
        "'David Rientjes'" <rientjes@...gle.com>,
        "'Daniel Kiper'" <daniel.kiper@...cle.com>,
        "'Igor Mammedov'" <imammedo@...hat.com>,
        "'Vitaly Kuznetsov'" <vkuznets@...hat.com>,
        "'LKML'" <linux-kernel@...r.kernel.org>,
        "'Michal Hocko'" <mhocko@...e.com>
Subject: Re: [PATCH 3/6] mm: remove return value from init_currently_empty_zone

On March 30, 2017 7:55 PM Michal Hocko wrote: 
> 
> From: Michal Hocko <mhocko@...e.com>
> 
> init_currently_empty_zone doesn't have any error to return yet it is
> still an int and callers try to be defensive and try to handle potential
> error. Remove this nonsense and simplify all callers.
> 
It is already cut off in 1/6 in this series?

<snip>

> -/* Can fail with -ENOMEM from allocating a wait table with vmalloc() or
> - * alloc_bootmem_node_nopanic()/memblock_virt_alloc_node_nopanic() */
> -static int __ref ensure_zone_is_initialized(struct zone *zone,
> +static void __ref ensure_zone_is_initialized(struct zone *zone,
>  			unsigned long start_pfn, unsigned long num_pages)
>  {
> -	if (zone_is_empty(zone))
> -		return init_currently_empty_zone(zone, start_pfn, num_pages);
> -
> -	return 0;
> +	if (!zone_is_empty(zone))
> +		init_currently_empty_zone(zone, start_pfn, num_pages);
>  }
Semantic change added?

Hillf