linux-kernel - Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 1 Apr 2017 09:12:01 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Wu Hao <hao.wu@...el.com>
Cc:     kbuild-all@...org, atull@...nel.org, moritz.fischer@...us.com,
        linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
        luwei.kang@...el.com, yi.z.zhang@...el.com, hao.wu@...el.com,
        Tim Whisonant <tim.whisonant@...el.com>,
        Enno Luebbers <enno.luebbers@...el.com>,
        Shiva Rao <shiva.rao@...el.com>,
        Christopher Rauer <christopher.rauer@...el.com>,
        Alan Tull <alan.tull@...el.com>,
        Xiao Guangrong <guangrong.xiao@...ux.intel.com>
Subject: Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub
 feature support

Hi Kang,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.11-rc4 next-20170331]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Wu-Hao/Intel-FPGA-Device-Drivers/20170401-052017
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc 

All warnings (new ones prefixed by >>):

   drivers/fpga/intel/fme-pr.c: In function 'fme_pr':
>> drivers/fpga/intel/fme-pr.c:278:30: warning: passing argument 2 of 'access_ok' makes pointer from integer without a cast [-Wint-conversion]
     if (!access_ok(VERIFY_READ, port_pr.buffer_address,
                                 ^~~~~~~
   In file included from arch/sparc/include/asm/uaccess.h:4:0,
                    from include/linux/uaccess.h:5,
                    from drivers/fpga/intel/fme-pr.c:25:
   arch/sparc/include/asm/uaccess_64.h:80:19: note: expected 'const void *' but argument is of type '__u64 {aka long long unsigned int}'
    static inline int access_ok(int type, const void __user * addr, unsigned long size)
                      ^~~~~~~~~

vim +/access_ok +278 drivers/fpga/intel/fme-pr.c

   262		if (!IS_ALIGNED(port_pr.buffer_size, 4))
   263			return -EINVAL;
   264	
   265		/* get fme header region */
   266		fme_hdr = get_feature_ioaddr_by_index(&pdev->dev,
   267						FME_FEATURE_ID_HEADER);
   268		if (WARN_ON(!fme_hdr))
   269			return -EINVAL;
   270	
   271		/* check port id */
   272		fme_capability.csr = readq(&fme_hdr->capability);
   273		if (port_pr.port_id >= fme_capability.num_ports) {
   274			dev_dbg(&pdev->dev, "port number more than maximum\n");
   275			return -EINVAL;
   276		}
   277	
 > 278		if (!access_ok(VERIFY_READ, port_pr.buffer_address,
   279					    port_pr.buffer_size))
   280			return -EFAULT;
   281	
   282		buf = vmalloc(port_pr.buffer_size);
   283		if (!buf)
   284			return -ENOMEM;
   285	
   286		if (copy_from_user(buf, (void __user *)port_pr.buffer_address,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (49798 bytes)