linux-kernel - Re: [PATCH] staging: iio: light: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <277e5ae4-5154-547a-147c-9fee105ba5a6@kernel.org>
Date:   Sat, 1 Apr 2017 11:41:06 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     simran singhal <singhalsimran0@...il.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: light: constify attribute_group structures

On 01/04/17 03:28, simran singhal wrote:
> As the event_attrs field of iio_info structures is constant, so these
> attribute_group structures can also be declared constant.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   15064	   1528	      0	  16592	   40d0
> drivers/staging/iio/light/tsl2x7x_core.o
> 
> File size after:
>    text	   data	    bss	    dec	    hex	filename
>   15192	   1400	      0	  16592	   40d0
> drivers/staging/iio/light/tsl2x7x_core.o
> 
> Signed-off-by: simran singhal <singhalsimran0@...il.com>
Not a big thing, but as this only touches the one driver, i would have
liked that mentioned in the naming of the patch...

I've added it.
Applied.
> ---
>  drivers/staging/iio/light/tsl2x7x_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
> index 0490c1d..9a0046a 100644
> --- a/drivers/staging/iio/light/tsl2x7x_core.c
> +++ b/drivers/staging/iio/light/tsl2x7x_core.c
> @@ -1676,7 +1676,7 @@ static const struct attribute_group tsl2X7X_device_attr_group_tbl[] = {
>  	},
>  };
>  
> -static struct attribute_group tsl2X7X_event_attr_group_tbl[] = {
> +static const struct attribute_group tsl2X7X_event_attr_group_tbl[] = {
>  	[ALS] = {
>  		.attrs = tsl2X7X_ALS_event_attrs,
>  		.name = "events",
>