linux-kernel - Re: [PATCH net v2] openvswitch: Fix ovs_flow_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170401.121812.2065199697531175615.davem@davemloft.net>
Date:   Sat, 01 Apr 2017 12:18:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yihung.wei@...il.com
Cc:     jbenc@...hat.com, joe@....org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] openvswitch: Fix ovs_flow_key_update()

From: Yi-Hung Wei <yihung.wei@...il.com>
Date: Thu, 30 Mar 2017 12:36:03 -0700

> ovs_flow_key_update() is called when the flow key is invalid, and it is
> used to update and revalidate the flow key. Commit 329f45bc4f19
> ("openvswitch: add mac_proto field to the flow key") introduces mac_proto
> field to flow key and use it to determine whether the flow key is valid.
> However, the commit does not update the code path in ovs_flow_key_update()
> to revalidate the flow key which may cause BUG_ON() on execute_recirc().
> This patch addresses the aforementioned issue.
> 
> Fixes: 329f45bc4f19 ("openvswitch: add mac_proto field to the flow key")
> Signed-off-by: Yi-Hung Wei <yihung.wei@...il.com>

Applied and queued up for -stable, thanks.