linux-kernel - Re: [PATCH v2] net: Remove unnecessary cast on void pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170401164821.036f1b41@plumbers-lap.home.lan>
Date:   Sat, 1 Apr 2017 16:48:21 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     simran singhal <singhalsimran0@...il.com>
Cc:     pablo@...filter.org, kadlec@...ckhole.kfki.hu, davem@...emloft.net,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com, gregkh@...uxfoundation.org,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        James Morris <jmorris@...ei.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Patrick McHardy <kaber@...sh.net>,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH v2] net: Remove unnecessary cast on void pointer

On Wed, 29 Mar 2017 00:35:16 +0530
simran singhal <singhalsimran0@...il.com> wrote:

> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> |
>   ((T *)x)[...]
> |
>   ((T*)x)->f
> |
> 
> - (T*)
>   e
> )
> 
> Unnecessary parantheses are also remove.
> 
> Signed-off-by: simran singhal <singhalsimran0@...il.com>

Looks good

Reviewed-by: Stephen Hemminger <stephen@...workplumber.org>