linux-kernel - Re: [PATCH] iio: adc: replace comma with a semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd41628a-bd56-0ccf-0baf-238a717049aa@kernel.org>
Date:   Sat, 1 Apr 2017 11:00:58 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Peter Meerwald-Stadler <pmeerw@...erw.net>,
        jacopo <jacopo@...ndi.org>
Cc:     Arushi Singhal <arushisinghal19971997@...il.com>,
        outreachy-kernel@...glegroups.com,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: replace comma with a semicolon

On 30/03/17 14:38, Peter Meerwald-Stadler wrote:
> 
>> On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote:
>>> Replace a comma between expression statements by a semicolon. This
>>> changes the semantics of the code, but given the current indentation
>>> appears to be what is intended.
> 
>> You can simply say that this fixes what appears to be a bug to me.
>> I wonder how this does even compile..
> 
> it's valid C and I think it does the correct thing (i.e. assign those 
> variables); the style is weird obviously
Hohum I am clearly going crazy in my old age.
Not a bug, but nice to fix so
Applied to the togreg branch of iio.git.  Sorry for messing my little
change up Jacopo!  Always worth checking a maintainer isn't being
an idiot when they apply your patches. As others will certify we
make plenty of mistakes.

Jonathan

> 
>> [1] https://marc.info/?l=linux-iio&m=148475728729617&w=2
>>
>>> Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
>>> ---
>>>  drivers/iio/adc/max11100.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/iio/adc/max11100.c b/drivers/iio/adc/max11100.c
>>> index 23c060e1b663..1180bcc22ff1 100644
>>> --- a/drivers/iio/adc/max11100.c
>>> +++ b/drivers/iio/adc/max11100.c
>>> @@ -124,8 +124,8 @@ static int max11100_probe(struct spi_device *spi)
>>>  	indio_dev->name = "max11100";
>>>  	indio_dev->info = &max11100_info;
>>>  	indio_dev->modes = INDIO_DIRECT_MODE;
>>> -	indio_dev->channels = max11100_channels,
>>> -	indio_dev->num_channels = ARRAY_SIZE(max11100_channels),
>>> +	indio_dev->channels = max11100_channels;
>>> +	indio_dev->num_channels = ARRAY_SIZE(max11100_channels);
>>>  
>>>  	state->vref_reg = devm_regulator_get(&spi->dev, "vref");
>>>  	if (IS_ERR(state->vref_reg))
>>> -- 
>>> 2.11.0
>>>
>>
>