linux-kernel - Re: [PATCH] tcmu: Skip Data-Out blocks before gathering Data-In buffer for BIDI case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1491175217.8846.60.camel@haakon3.risingtidesystems.com>
Date:   Sun, 02 Apr 2017 16:20:17 -0700
From:   "Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:     lixiubo@...s.chinamobile.com
Cc:     mchristi@...hat.com, agrover@...hat.com, iliastsi@...ikto.com,
        namei.unix@...il.com, sheng@...ker.org, linux-scsi@...r.kernel.org,
        target-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tcmu: Skip Data-Out blocks before gathering Data-In
 buffer for BIDI case

On Fri, 2017-03-31 at 10:35 +0800, lixiubo@...s.chinamobile.com wrote:
> From: Xiubo Li <lixiubo@...s.chinamobile.com>
> 
> For the bidirectional case, the Data-Out buffer blocks will always at
> the head of the tcmu_cmd's bitmap, and before gathering the Data-In
> buffer, first of all it should skip the Data-Out ones, or the device
> supporting BIDI commands won't work.
> 
> Fixed: 26418649eead ("target/user: Introduce data_bitmap, replace
> 		data_length/data_head/data_tail")
> Reported-by: Ilias Tsitsimpis <iliastsi@...ikto.com>
> Signed-off-by: Xiubo Li <lixiubo@...s.chinamobile.com>
> ---
>  drivers/target/target_core_user.c | 48 +++++++++++++++++++++++++++------------
>  1 file changed, 33 insertions(+), 15 deletions(-)

Applied to target-pending/master, with a CC' to linux-4.6.y stable.

Thanks Xiubo + Ilias.