linux-kernel - Re: [PATCH 1/2] input: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 02 Apr 2017 08:10:15 +0800
From:   jeffy <jeffy.chen@...k-chips.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:     linux-kernel@...r.kernel.org, briannorris@...omium.org,
        dbasehore@...gle.com, dianders@...omium.org,
        Gwendal Grignou <gwendal@...omium.org>,
        Vic Yang <victoryang@...gle.com>, linux-input@...r.kernel.org,
        Enric Balletbo Serra <enric.balletbo@...labora.com>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 1/2] input: cros_ec_keyb: Report wakeup events

Hi Dmitry,

On 04/02/2017 01:14 AM, Dmitry Torokhov wrote:
> On Sat, Apr 01, 2017 at 10:12:37AM -0700, Dmitry Torokhov wrote:
>> Hi Jeffy,
>>
>> On Thu, Mar 30, 2017 at 05:50:49PM +0800, Jeffy Chen wrote:
>>> Report wakeup events when process events.
>>>
>>> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
>>> ---
>>>
>>>   drivers/input/keyboard/cros_ec_keyb.c | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
>>> index 6a250d6..a93d55f 100644
>>> --- a/drivers/input/keyboard/cros_ec_keyb.c
>>> +++ b/drivers/input/keyboard/cros_ec_keyb.c
>>> @@ -286,6 +286,9 @@ static int cros_ec_keyb_work(struct notifier_block *nb,
>>>   		return NOTIFY_DONE;
>>>   	}
>>>
>>> +	if (device_may_wakeup(ckdev->dev))
>>> +		pm_wakeup_event(ckdev->dev, 0);
>>> +
>>>   	return NOTIFY_OK;
>>>   }
>>>
>>> @@ -632,6 +635,12 @@ static int cros_ec_keyb_probe(struct platform_device *pdev)
>>>   		return err;
>>>   	}
>>>
>>> +	err = device_init_wakeup(dev, 1);
>>
>> In the other patch you are adding "wakeup-source" to the DT binding, but
>> here you mark all EC deices as wakeup sources. You need to use
>> device_property_read_bool(dev, "wakeup-source") and use the result in
>> call to device_init_wakeup().
>
> And please also update device tree binding doc for the driver.
>
oops, sorry, i thought that dts property is needed to enable a wakeup 
source...but obviously it's not, only gpio-keys requires that.

so the dts patch is not needed, will remove in next version, thanx.
>>
>>> +	if (err) {
>>> +		dev_err(dev, "cannot init wakeup: %d\n", err);
>>> +		return err;
>>> +	}
>>> +
>>>   	return 0;
>>>   }
>>>
>>
>> Thanks.
>>
>> --
>> Dmitry
>