linux-kernel - Re: [PATCH] iio: humidity: hts221_buffer: Remove unnecessary cast on void pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f982f9c3-78a3-be61-30a2-1000f4e681d7@kernel.org>
Date:   Sun, 2 Apr 2017 09:51:21 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     simran singhal <singhalsimran0@...il.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: humidity: hts221_buffer: Remove unnecessary cast on
 void pointer

On 01/04/17 15:14, simran singhal wrote:
> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> |
>   ((T *)x)[...]
> |
>   ((T*)x)->f
> |
> - (T*)
>   e
> )
> 
> Signed-off-by: simran singhal <singhalsimran0@...il.com>
I made a miinor change to the title to drop the _buffer.
That's naming the exact file, whereas keeping it to the driver
is fine (so just hts221).

Applied.

Thanks,

Jonathan
> ---
>  drivers/iio/humidity/hts221_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/humidity/hts221_buffer.c b/drivers/iio/humidity/hts221_buffer.c
> index 72ddcda..7d19a3d 100644
> --- a/drivers/iio/humidity/hts221_buffer.c
> +++ b/drivers/iio/humidity/hts221_buffer.c
> @@ -41,7 +41,7 @@ static const struct iio_trigger_ops hts221_trigger_ops = {
>  
>  static irqreturn_t hts221_trigger_handler_thread(int irq, void *private)
>  {
> -	struct hts221_hw *hw = (struct hts221_hw *)private;
> +	struct hts221_hw *hw = private;
>  	u8 status;
>  	int err;
>  
>