linux-kernel - Re: [PATCH v2 1/2] extcon: max77843: improve the code and minimize duplicated lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <58E1FF7A.6020603@samsung.com>
Date:   Mon, 03 Apr 2017 16:53:30 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Andi Shyti <andi.shyti@...il.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Jaewon Kim <jaewon02.kim@...sung.com>
Cc:     Seung-Woo Kim <sw0312.kim@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-kernel@...r.kernel.org, Andi Shyti <andi.shyti@...sung.com>,
        Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH v2 1/2] extcon: max77843: improve the code and minimize
 duplicated lines

Hi,

Actually, I checked this patch on following four case.
It is same operation between before and after.
-------------------------------------------------------------
       | adc                       | chg_type               |
-------------------------------------------------------------
case 1 | MAX77843_MUIC_ADC_GROUND  | MAX77843_MUIC_CHG_NONE |
case 2 | MAX77843_MUIC_ADC_GROUND  |                        |
case 3 |                           | MAX77843_MUIC_CHG_NONE |
case 4 |                           |                        |
-------------------------------------------------------------


But, I don't want to apply this patch.

By applying this patch, I think there is no huge benefits
and certainly I prefer to remain the all descriptions for specific use-case.
(- This patch deletes the 13 lines and add new 8 lines except for the comment.)

On 2017년 04월 02일 14:35, Andi Shyti wrote:
> From: Andi Shyti <andi.shyti@...sung.com>
> 
> Signed-off-by: Andi Shyti <andi.shyti@...sung.com>
> ---
>  drivers/extcon/extcon-max77843.c | 33 ++++++++-------------------------
>  1 file changed, 8 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index 6e722d552cf1..fcdabc4b4025 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -264,37 +264,20 @@ static int max77843_muic_get_cable_type(struct max77843_muic_info *info,
>  		chg_type = info->status[MAX77843_MUIC_STATUS2] &
>  				MAX77843_MUIC_STATUS2_CHGTYP_MASK;
>  
> -		/* Check GROUND accessory with charger cable */
> -		if (adc == MAX77843_MUIC_ADC_GROUND) {
> -			if (chg_type == MAX77843_MUIC_CHG_NONE) {
> -				/*
> -				 * The following state when charger cable is
> -				 * disconnected but the GROUND accessory still
> -				 * connected.
> -				 */
> -				*attached = false;
> -				cable_type = info->prev_chg_type;
> -				info->prev_chg_type = MAX77843_MUIC_CHG_NONE;
> -			} else {
> -
> -				/*
> -				 * The following state when charger cable is
> -				 * connected on the GROUND accessory.
> -				 */
> -				*attached = true;
> -				cable_type = MAX77843_MUIC_CHG_GND;
> -				info->prev_chg_type = MAX77843_MUIC_CHG_GND;
> -			}
> -			break;
> -		}
> -
>  		if (chg_type == MAX77843_MUIC_CHG_NONE) {
>  			*attached = false;
>  			cable_type = info->prev_chg_type;
>  			info->prev_chg_type = MAX77843_MUIC_CHG_NONE;
>  		} else {
>  			*attached = true;
> -			cable_type = info->prev_chg_type = chg_type;
> +			switch (adc) {
> +			case MAX77843_MUIC_ADC_GROUND:
> +				info->prev_chg_type = MAX77843_MUIC_CHG_GND;
> +				break;
> +			default:
> +				info->prev_chg_type = chg_type;
> +			}
> +			cable_type = info->prev_chg_type;
>  		}
>  		break;
>  	case MAX77843_CABLE_GROUP_ADC_GND:
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics