linux-kernel - Re: [tip:x86/platform 1/1] platform_bt.c:undefined reference to `gpiod_add_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdbThAmy5OVFzW2=FYeV6goWXJYMBM_QUkJWRC2UD7t7g@mail.gmail.com>
Date:   Mon, 3 Apr 2017 12:44:11 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     kbuild test robot <fengguang.wu@...el.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        kbuild-all@...org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        tipbuild@...or.com, Ingo Molnar <mingo@...nel.org>
Subject: Re: [tip:x86/platform 1/1] platform_bt.c:undefined reference to `gpiod_add_lookup_table'

On Mon, Apr 3, 2017 at 12:36 PM, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Mon, Apr 3, 2017 at 12:31 PM, Arnd Bergmann <arnd@...db.de> wrote:
>> On Mon, Apr 3, 2017 at 10:13 AM, Andy Shevchenko
>> <andy.shevchenko@...il.com> wrote:
>>> On Mon, Apr 3, 2017 at 2:23 AM, kbuild test robot
>>> <fengguang.wu@...el.com> wrote:

>>>>    arch/x86/built-in.o: In function `tng_bt_sfi_setup':
>>>>>> platform_bt.c:(.init.text+0x13a30): undefined reference to `gpiod_add_lookup_table'
>>
>> I'd guess it's a missing dependency on GPIOLIB
>
> Apparently not this one.
>
> The module is purely built whenever HCIUART_BCM is defined which is a
> consumer of GPIO.

> And that one does not have a dependency.

...and they should not. So, there are two ways of fix this:
- add a stub for gpiod_add_lookup_table() for !GPIOLIB case, or
- add ifdeffery around this code here (with obvious increase of ugliness).

-- 
With Best Regards,
Andy Shevchenko