linux-kernel - Re: [kbuild-all] [PATCH] net: hns: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170403025229.4s5phuckehwmucbt@wfg-t540p.sh.intel.com>
Date:   Mon, 3 Apr 2017 10:52:29 +0800
From:   Fengguang Wu <lkp@...el.com>
To:     David Miller <davem@...emloft.net>
Cc:     salil.mehta@...wei.com, netdev@...r.kernel.org,
        mehta.salil.lnk@...il.com, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com, kbuild-all@...org, lipeng321@...wei.com,
        yisen.zhuang@...wei.com, lkp@...el.com
Subject: Re: [kbuild-all] [PATCH] net: hns: fix boolreturn.cocci warnings

Hi David,

On Sun, Apr 02, 2017 at 07:44:02PM -0700, David Miller wrote:
>From: kbuild test robot <lkp@...el.com>
>Date: Sat, 1 Apr 2017 07:50:55 +0800
>
>> drivers/net/ethernet/hisilicon/hns/hns_enet.c:1548:8-9: WARNING: return of 0/1 in function 'hns_enable_serdes_lb' with return type bool
>>
>>  Return statements in functions returning bool should use
>>  true/false instead of 1/0.
>> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>>
>> CC: lipeng <lipeng321@...wei.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
>
>This doesn't apply to any of my trees.

It's a reply to Salil's patch

        [PATCH net 08/19] net: hns: Fix to adjust buf_size of ring according to mtu

and so is based on that patch.

What can the robot improve to avoid you confusing it as a general
patch for the net master trees? One possible way is to change title to

        [PATCH for Salil] net: hns: fix boolreturn.cocci warnings
        ^^^^^^^^^^^^^^^^^

Regards,
Fengguang