linux-kernel - [PATCH 1/3] extcon: intel-cht-wc: Make error messages consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170403112630.30625-1-hdegoede@redhat.com>
Date:   Mon,  3 Apr 2017 13:26:28 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Cc:     Hans de Goede <hdegoede@...hat.com>, Takashi Iwai <tiwai@...e.de>,
        linux-kernel@...r.kernel.org
Subject: [PATCH 1/3] extcon: intel-cht-wc: Make error messages consistent

Before this commit the error messages were a mix of "Failed to ..." and
"Error ...ing ...".

This commit makes all the error messages consistently use "Error ...ing".

Signed-off-by: Hans de Goede <hdegoede@...hat.com>
---
 drivers/extcon/extcon-intel-cht-wc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/extcon/extcon-intel-cht-wc.c b/drivers/extcon/extcon-intel-cht-wc.c
index 0a05cc3..f1c43af 100644
--- a/drivers/extcon/extcon-intel-cht-wc.c
+++ b/drivers/extcon/extcon-intel-cht-wc.c
@@ -252,7 +252,7 @@ static int cht_wc_extcon_sw_control(struct cht_wc_extcon_data *ext, bool enable)
 	val = enable ? mask : 0;
 	ret = regmap_update_bits(ext->regmap, CHT_WC_CHGRCTRL0, mask, val);
 	if (ret)
-		dev_err(ext->dev, "Failed setting sw control: %d\n", ret);
+		dev_err(ext->dev, "Error setting sw control: %d\n", ret);
 
 	return ret;
 }
@@ -288,7 +288,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev)
 	/* Register extcon device */
 	ret = devm_extcon_dev_register(ext->dev, ext->edev);
 	if (ret) {
-		dev_err(ext->dev, "Failed to register extcon device\n");
+		dev_err(ext->dev, "Error registering extcon device: %d\n", ret);
 		goto disable_sw_control;
 	}
 
@@ -301,7 +301,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev)
 	ret = devm_request_threaded_irq(ext->dev, irq, NULL, cht_wc_extcon_isr,
 					IRQF_ONESHOT, pdev->name, ext);
 	if (ret) {
-		dev_err(ext->dev, "Failed to request interrupt\n");
+		dev_err(ext->dev, "Error requesting interrupt: %d\n", ret);
 		goto disable_sw_control;
 	}
 
@@ -310,7 +310,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev)
 			   (int)~(CHT_WC_PWRSRC_VBUS | CHT_WC_PWRSRC_ID_GND |
 				  CHT_WC_PWRSRC_ID_FLOAT));
 	if (ret) {
-		dev_err(ext->dev, "Failed to write the irq-mask: %d\n", ret);
+		dev_err(ext->dev, "Error writing irq-mask: %d\n", ret);
 		goto disable_sw_control;
 	}
 
-- 
2.9.3