linux-kernel - Re: [PATCH] pinctrl: core: Fix pinctrl_register_and_init() with pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2017 09:00:20 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Gary Bisson <gary.bisson@...ndarydevices.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Haojian Zhuang <haojian.zhuang@...aro.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Mika Penttilä <mika.penttila@...tfour.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Nishanth Menon <nm@...com>, Shawn Guo <shawnguo@...nel.org>,
        Stefan Agner <stefan@...er.ch>
Subject: Re: [PATCH] pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable()

Hi Tony,

On Thu, Mar 30, 2017 at 1:16 PM, Tony Lindgren <tony@...mide.com> wrote:
> Recent pinctrl changes to allow dynamic allocation of pins exposed one
> more issue with the pinctrl pins claimed early by the controller itself.
> This caused a regression for IMX6 pinctrl hogs.
>
> Before enabling the pin controller driver we need to wait until it has
> been properly initialized, then claim the hogs, and only then enable it.
>
> To fix the regression, split the code into pinctrl_claim_hogs() and
> pinctrl_enable(). And then let's require that pinctrl_enable() is always
> called by the pin controller driver when ready after calling
> pinctrl_register_and_init().
>
> Depends-on: 950b0d91dc10 ("pinctrl: core: Fix regression caused by delayed
> work for hogs")
> Fixes: df61b366af26 ("pinctrl: core: Use delayed work for hogs")
> Fixes: e566fc11ea76 ("pinctrl: imx: use generic pinctrl helpers for
> managing groups")
> Cc: Fabio Estevam <festevam@...il.com>
> Cc: Gary Bisson <gary.bisson@...ndarydevices.com>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Haojian Zhuang <haojian.zhuang@...aro.org>
> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Cc: Mika Penttilä <mika.penttila@...tfour.com>
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Cc: Nishanth Menon <nm@...com>
> Cc: Shawn Guo <shawnguo@...nel.org>
> Cc: Stefan Agner <stefan@...er.ch>
> Signed-off-by: Tony Lindgren <tony@...mide.com>

Your patch fixes the pinctrl hog issue on a imx53-qsb board, thanks:

Tested-by: Fabio Estevam <fabio.estevam@....com>