linux-kernel - Re: [tip:x86/asm] debug: Fix __bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170403122501.GA3093@worktop>
Date:   Mon, 3 Apr 2017 14:25:01 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     hpa@...or.com
Cc:     linux-tip-commits@...r.kernel.org,
        tip-bot for Peter Zijlstra <tipbot@...or.com>,
        torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
        mingo@...nel.org, tglx@...utronix.de, fengguang.wu@...el.com
Subject: Re: [tip:x86/asm] debug: Fix __bug_table[] in arch linker scripts

On Mon, Apr 03, 2017 at 02:57:48AM -0700, hpa@...or.com wrote:
> On April 3, 2017 1:27:49 AM PDT, tip-bot for Peter Zijlstra <tipbot@...or.com> wrote:
> >diff --git a/arch/x86/kernel/vmlinux.lds.S
> >b/arch/x86/kernel/vmlinux.lds.S
> >index c74ae9c..c8a3b61 100644
> >--- a/arch/x86/kernel/vmlinux.lds.S
> >+++ b/arch/x86/kernel/vmlinux.lds.S
> >@@ -146,6 +146,7 @@ SECTIONS
> > 		_edata = .;
> > 	} :data
> > 
> >+	BUG_TABLE
> > 
> > 	. = ALIGN(PAGE_SIZE);
> > 	__vvar_page = .;
> 
> Case in point why we want structured linker tables, btw...

Yes.

Btw, can you explain why x86 builds and works without this patch?
Because as far as I understand this (which isn't very far), we should
fail linking with an unresolved symbol without this.