linux-kernel - Re: [PATCH V7 4/7] mfd: da9061: MFD core support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170403143049.qyi4dagwi4cdenok@dell>
Date:   Mon, 3 Apr 2017 15:30:49 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Steve Twiss <stwiss.opensource@...semi.com>
Cc:     LINUX-KERNEL <linux-kernel@...r.kernel.org>,
        DEVICETREE <devicetree@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        LINUX-INPUT <linux-input@...r.kernel.org>,
        LINUX-PM <linux-pm@...r.kernel.org>,
        LINUX-WATCHDOG <linux-watchdog@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Support Opensource <Support.Opensource@...semi.com>,
        Wim Van Sebroeck <wim@...ana.be>,
        Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH V7 4/7] mfd: da9061: MFD core support

On Mon, 03 Apr 2017, Steve Twiss wrote:

> On 03 April 2017 15:12, Lee Jones wrote:
> 
> > > @@ -475,7 +855,25 @@ static int da9062_i2c_probe(struct i2c_client *i2c,
> > >  		return -EINVAL;
> > >  	}
> > >
> > > -	chip->regmap = devm_regmap_init_i2c(i2c, &da9062_regmap_config);
> > > +	switch (chip->chip_type) {
> > > +	case(COMPAT_TYPE_DA9061):
> > 
> > Brackets around the case value?
> > 
> > That's a new one on me.
> 
> Hm. Do you want me to resend it without braces?

Yes please.  And a space after the 'case'.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog