linux-kernel - Re: [PATCH 2/3] dt-bindings: Add bindings for nvidia,tegra186-ccplex-cluster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40534e51-db02-6eb2-2426-b34a5ea0f61d@kapsi.fi>
Date:   Mon, 3 Apr 2017 18:19:49 +0300
From:   Mikko Perttunen <cyndis@...si.fi>
To:     Jon Hunter <jonathanh@...dia.com>,
        Mikko Perttunen <mperttunen@...dia.com>, rjw@...ysocki.net,
        viresh.kumar@...aro.org, thierry.reding@...il.com
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: Add bindings for
 nvidia,tegra186-ccplex-cluster



On 04/03/2017 05:24 PM, Jon Hunter wrote:
>
> On 03/04/17 13:42, Mikko Perttunen wrote:
>> The Tegra186 CCPLEX_CLUSTER area contains memory-mapped
>> registers that initiate CPU frequency/voltage transitions.
>>
>> Signed-off-by: Mikko Perttunen <mperttunen@...dia.com>
>> ---
>>  .../arm/tegra/nvidia,tegra186-ccplex-cluster.txt   | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt
>>
>> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt
>> new file mode 100644
>> index 000000000000..50cd615219e9
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-ccplex-cluster.txt
>> @@ -0,0 +1,22 @@
>> +NVIDIA Tegra CCPLEX_CLUSTER area
>> +
>> +Required properties:
>> +- compatible: Should contain one of the following:
>> +  - "nvidia,tegra186-ccplex-cluster": for Tegra186
>
> Nit pick ... any reason why we append 'cluster' here? The TRM just says
> the "CPU Complex" consists of two CPU clusters. So
> "nvidia,tegra186-cpu-complex" or "nvidia,tegra186-ccplex" seems fine.
>
> BTW, I do see references in the TRM to CCPLEX_CLUSTER0/1, but never
> CCPLEX_CLUSTER in reference to both. I think it is just CCPLEX AFAICT.

The reason was that the MMIO aperture is called "CCPLEX_CLUSTER" in the 
address map. But I agree it's not a very descriptive name.

>
> Cheers
> Jon
>