linux-kernel - Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOzquK8PfFL+OxtARdh76MNyDw_PfTfz+uLfp=8JSn+HDwq+Dw@mail.gmail.com>
Date:   Mon, 3 Apr 2017 11:38:22 +0530
From:   Prasant Jalan <prasant.jalan@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Larry.Finger@...inger.net,
        Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Greg KH <gregkh@...uxfoundation.org>, geliangtang@....com,
        raphael.beamonte@...il.com, vijaikumar.kanagarajan@...il.com,
        Souptick Joarder <jrdr.linux@...il.com>,
        driverdevel <devel@...verdev.osuosl.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue

On Mon, Apr 3, 2017 at 10:27 AM, Joe Perches <joe@...ches.com> wrote:
> On Mon, 2017-04-03 at 09:43 +0530, Prasant Jalan wrote:
>> On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan <prasant.jalan@...il.com> wrote:
>> > Checkpatch emits WARNING: Avoid multiple line dereference.
>> >
>> > Trivial indentation improvement helps fix the checkpatch warning.
> []
>> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> []
>> > @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter,
>> >                                                            &pframe[10], 6);
>> >                         }
>> >                         if (pqospriv->qos_option == 1)
>> > -                                       priority[0] = (u8)pxmitframe->
>> > -                                                     attrib.priority;
>> > +                               priority[0] = (u8)pxmitframe->attrib.priority;
>> >                         r8712_secmicappend(&micdata, &priority[0], 4);
>> >                         payload = pframe;
>> >                         for (curfragnum = 0; curfragnum < pattrib->nr_frags;
>> >                              curfragnum++) {
>> >                                 payload = (u8 *)RND4((addr_t)(payload));
>> > -                               payload = payload + pattrib->
>> > -                                         hdrlen + pattrib->iv_len;
>> > +                               payload = payload + pattrib->hdrlen +
>> > +                                         pattrib->iv_len;
>
> += would be shorter

Hi Joe,

Looks like back to school for me for overlooking such a trivial thing.

Thanks for the pointer, I will update the patch and resend.


Regards, Prasant