linux-kernel - Re: [PATCH v2 2/2] regulator: hi655x: Bump parent pmic module use count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170403171912.uv3b3sqfw5zaoyk7@sirena.org.uk>
Date:   Mon, 3 Apr 2017 18:19:12 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Jeremy Linton <lintonrjeremy@...il.com>
Cc:     linux-kernel@...r.kernel.org, lgirdwood@...il.com,
        puck.chen@...ilicon.com, lee.jones@...aro.org
Subject: Re: [PATCH v2 2/2] regulator: hi655x: Bump parent pmic module use
 count

On Mon, Apr 03, 2017 at 12:28:43AM -0500, Jeremy Linton wrote:
> The hi655x-regulator driver depends on the parent pmic/mfc
> device driver but doesn't increase its use count. This results
> in system crashes if the parent module is unloaded while the
> regulators are still in use. Add explicit module get/put
> calls to keep the parent from being unloaded.

Once again, it is a complete hack to do this at the individual driver
level.  Please don't ignore review feedback.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)