linux-kernel - Re: [PATCH] KEYS: encrypted: avoid encrypting/decrypting stack buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2017 11:21:57 -0700
From:   Eric Biggers <ebiggers3@...il.com>
To:     Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:     keyrings@...r.kernel.org, David Howells <dhowells@...hat.com>,
        Andy Lutomirski <luto@...nel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Eric Biggers <ebiggers@...gle.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] KEYS: encrypted: avoid encrypting/decrypting stack
 buffers

On Mon, Apr 03, 2017 at 11:55:42AM -0400, Mimi Zohar wrote:
> 
> This patch removes calculating the "padlen".  Will this change break
> other use cases?
> 

No, the number of bytes being encrypted is still 'encrypted_datalen' which is
passed to skcipher_request_set_crypt().  It's okay if the input scatterlist is
longer than that; only the first 'encrypted_datalen' bytes will be used.

- Eric