linux-kernel - Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170403222010.xgbf7imyieyfroqr@rob-hp-laptop>
Date:   Mon, 3 Apr 2017 17:20:10 -0500
From:   Rob Herring <robh@...nel.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/7] mfd: retu: Add OF device ID table

On Mon, Apr 03, 2017 at 11:45:14AM -0400, Javier Martinez Canillas wrote:
> Hello Lee,
> 
> On 04/03/2017 07:15 AM, Lee Jones wrote:
> 
> [snip]
> 
> >>  
> >> +static const struct of_device_id retu_of_match[] = {
> >> +	{ .compatible = "nokia,retu-mfd" },
> >> +	{ .compatible = "nokia,tahvo-mfd" },
> > 
> > Please drop the "-mfd".
> > 
> 
> Yes, I also didn't like it but I didn't want to change it since that would
> mean that backward compatiblity and bisect-ability will be broken by this
> change.
> 
> In other words, just adding a vendor prefix won't cause an issue if patches
> are merged independently since if DTS patches are merged before, the driver
> will still lookup using the I2C device ID table. And if the drivers patches
> are picked before, the DTS will match using the OF device ID table.
> 
> But changing to "nokia,retu" and "nokia,tahvo" means that you will need to
> pick all patches and also that the DTS and drivers changes will have to be
> done in the same patch. If you are OK with that, then I can change in the
> next version.

tahvo is not documented nor used in any dts (in the kernel at least). 
retu is used by 1 board and happened to work, but was never documented. 
So I think it is okay to change unless the N800 folks object.

Rob