linux-kernel - Re: [PATCH v2] scsi: storvsc: Add support for FC rport.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170404065331.GA2626@infradead.org>
Date:   Mon, 3 Apr 2017 23:53:31 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Cathy Avery <cavery@...hat.com>
Cc:     Christoph Hellwig <hch@...radead.org>, kys@...rosoft.com,
        haiyangz@...rosoft.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, stephen@...workplumber.org,
        dan.carpenter@...cle.com, devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH v2] scsi: storvsc: Add support for FC rport.

On Mon, Apr 03, 2017 at 09:14:02AM -0400, Cathy Avery wrote:
> On 04/03/2017 08:17 AM, Christoph Hellwig wrote:
> > >   	if (host->transportt == fc_transport_template) {
> > > +		struct fc_rport_identifiers ids = {
> > > +			.roles = FC_PORT_ROLE_FCP_TARGET,
> > > +		};
> > I don't think storvsc ever acts as FCP target.
> 
> In order to implement the work around so that the scsi scan works indicating
> FC_PORT_ROLE_FCP_TARGET as a role was necessary due to its test in
> fc_scsi_scan_rport. The idea here is to avoid making any changes to the
> fc_transport driver which was of some concern.

Please add a FC_PORT_ROLE_FCP_DUMMY_INITIATOR role instead.