linux-kernel - Re: [RFC][PATCHv2 7/8] printk: add printk emergency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Apr 2017 17:29:30 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>, Jan Kara <jack@...e.cz>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Eric Biederman <ebiederm@...ssion.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, Pavel Machek <pavel@....cz>,
        Len Brown <len.brown@...el.com>, linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [RFC][PATCHv2 7/8] printk: add printk emergency_mode parameter

On (04/03/17 17:29), Petr Mladek wrote:
[..]
> > +module_param_cb(emergency_mode,
> > +		&printk_kthread_disabled_ops,
> > +		&printk_kthread_disabled,
> > +		0644);
> > +MODULE_PARM_DESC(emergency_mode,
> > +		"don't offload message printing to printk kthread");
> 
> I wonder if we could make this easier. Something like:
> 
> static bool printk_force_emergency;
> module_param_named(force_emergency, printk_force_emergency,
> 		   bool, S_IRUGO | S_IWUSR);

yes, can do. thanks.

> and use it instead of printk_kthread_disabled variable. It was
> confusing anyway. You already mentioned that it did not
> stop the kthread.

yeah, I didn't like the `printk_kthread_disabled' naming, but
at the same time didn't feel like having `printk_emergency' and
`printk_forced_emergency'. will take a look.

	-ss