[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 04 Apr 2017 12:40:54 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Neil Armstrong <narmstrong@...libre.com>
Cc: dri-devel@...ts.freedesktop.org,
laurent.pinchart+renesas@...asonboard.com, architt@...eaurora.org,
mchehab@...nel.org, Jose.Abreu@...opsys.com,
kieran.bingham@...asonboard.com, linux-amlogic@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
linux-media@...r.kernel.org, hans.verkuil@...co.com,
sakari.ailus@...ux.intel.com
Subject: Re: [PATCH v6 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings
Hi Neil,
Thank you for the patch.
On Monday 03 Apr 2017 16:42:36 Neil Armstrong wrote:
> Some display pipelines can only provide non-RBG input pixels to the HDMI TX
> Controller, this patch takes the pixel format from the plat_data if
> provided.
The commit message doesn't seem to match the subject line.
> Reviewed-by: Jose Abreu <joabreu@...opsys.com>
> Reviewed-by: Archit Taneja <architt@...eaurora.org>
> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 326 +++++++++++++++++++--------
> include/drm/bridge/dw_hdmi.h | 63 ++++++
> 2 files changed, 294 insertions(+), 95 deletions(-)
[snip]
> diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h
> index bcceee8..45c2c15 100644
> --- a/include/drm/bridge/dw_hdmi.h
> +++ b/include/drm/bridge/dw_hdmi.h
> @@ -14,6 +14,67 @@
>
> struct dw_hdmi;
>
> +/**
> + * DOC: Supported input formats and encodings
> + *
> + * Depending on the Hardware configuration of the Controller IP, it
> supports
> + * a subset of the following input formats and encodings on it's internal
> + * 48bit bus.
> + *
s/it's/its/
[snip]
Apart from that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists