linux-kernel - Re: [PATCH v2 6/6] hpet: fix style issue about braces and alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1491277402.27353.68.camel@perches.com>
Date:   Mon, 03 Apr 2017 20:43:22 -0700
From:   Joe Perches <joe@...ches.com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>, clemens@...isch.de,
        arnd@...db.de, gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/6] hpet: fix style issue about braces and alignment

On Mon, 2017-04-03 at 14:15 +0200, Corentin Labbe wrote:
> This patch fix all style issue for braces and alignment
[]
> diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
[]
> @@ -255,9 +255,9 @@ static int hpet_open(struct inode *inode, struct file *file)
>  
>  	for (devp = NULL, hpetp = hpets; hpetp && !devp; hpetp = hpetp->hp_next)
>  		for (i = 0; i < hpetp->hp_ntimer; i++)
> -			if (hpetp->hp_dev[i].hd_flags & HPET_OPEN)
> +			if (hpetp->hp_dev[i].hd_flags & HPET_OPEN) {
>  				continue;
> -			else {
> +			} else {
>  				devp = &hpetp->hp_dev[i];
>  				break;
>  			}

Perhaps this is clearer as:

 	for (devp = NULL, hpetp = hpets; hpetp && !devp; hpetp = hpetp->hp_next) {
		for (i = 0; i < hpetp->hp_ntimer; i++) {
			if (!(hpetp->hp_dev[i].hd_flags & HPET_OPEN)) {
				devp = &hpetp->hp_dev[i];
				break;
			}
		}
	}
		
> @@ -304,9 +304,9 @@ hpet_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
>  		devp->hd_irqdata = 0;
>  		spin_unlock_irq(&hpet_lock);
>  
> -		if (data)
> +		if (data) {
>  			break;
> -		else if (file->f_flags & O_NONBLOCK) {
> +		} else if (file->f_flags & O_NONBLOCK) {

break; else is almost always better as break
and reduced indentation