lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 4 Apr 2017 11:25:41 -0600
From:   Logan Gunthorpe <>
To:     Sagi Grimberg <>, Christoph Hellwig <>,
        "James E.J. Bottomley" <>,
        "Martin K. Petersen" <>,
        Jens Axboe <>,
        Steve Wise <>,
        Stephen Bates <>,
        Max Gurtovoy <>,
        Dan Williams <>,
        Keith Busch <>,
        Jason Gunthorpe <>
Subject: Re: [RFC 4/8] p2pmem: Add debugfs "stats" file

On 04/04/17 04:46 AM, Sagi Grimberg wrote:
>> +    p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL);
>> +    if (!p2pmem_debugfs_root)
>> +        pr_info("could not create debugfs entry, continuing\n");
>> +
> Why continue? I think it'd be better to just fail it.

Yup, agreed. This should probably also be PTR_ERR as well.

> Besides, this can be safely squashed into patch 1.

Sure, the only real reason I kept it separate was it was authored by
Steve Wise.


Powered by blists - more mailing lists