linux-kernel - [tip:efi/core] efi/pstore: Return error code (if any) from efi_pstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-92d3757f1043f3213b2fef78437577d19b7de209@git.kernel.org>
Date:   Wed, 5 Apr 2017 01:54:38 -0700
From:   tip-bot for Evgeny Kalugin <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hpa@...or.com, matt@...eblueprint.co.uk, tglx@...utronix.de,
        mingo@...nel.org, peterz@...radead.org,
        torvalds@...ux-foundation.org, evgeny.kalugin@...el.com,
        linux-kernel@...r.kernel.org, ard.biesheuvel@...aro.org
Subject: [tip:efi/core] efi/pstore: Return error code (if any) from
 efi_pstore_write()

Commit-ID:  92d3757f1043f3213b2fef78437577d19b7de209
Gitweb:     http://git.kernel.org/tip/92d3757f1043f3213b2fef78437577d19b7de209
Author:     Evgeny Kalugin <evgeny.kalugin@...el.com>
AuthorDate: Tue, 4 Apr 2017 17:02:42 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 5 Apr 2017 09:27:51 +0200

efi/pstore: Return error code (if any) from efi_pstore_write()

For some reason return value from actual variable setting was ignored.
With this change error code get transferred upwards through call stack.

Signed-off-by: Evgeny Kalugin <evgeny.kalugin@...el.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Matt Fleming <matt@...eblueprint.co.uk>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: linux-efi@...r.kernel.org
Link: http://lkml.kernel.org/r/20170404160245.27812-9-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 drivers/firmware/efi/efi-pstore.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
index f402ba2..6b5acef 100644
--- a/drivers/firmware/efi/efi-pstore.c
+++ b/drivers/firmware/efi/efi-pstore.c
@@ -274,9 +274,9 @@ static int efi_pstore_write(enum pstore_type_id type,
 	for (i = 0; i < DUMP_NAME_LEN; i++)
 		efi_name[i] = name[i];
 
-	efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
-			      !pstore_cannot_block_path(reason),
-			      size, psi->buf);
+	ret = efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
+				    !pstore_cannot_block_path(reason),
+				    size, psi->buf);
 
 	if (reason == KMSG_DUMP_OOPS)
 		efivar_run_worker();