linux-kernel - RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE3E3DFA698D6144A7445C92D1D41E2F10BF6A4B@SHSMSX103.ccr.corp.intel.com>
Date:   Wed, 5 Apr 2017 01:12:59 +0000
From:   "Song, Hongyan" <hongyan.song@...el.com>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        "rrs@...earchut.com" <rrs@...earchut.com>,
        linux-iio <linux-iio@...r.kernel.org>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll
 value function order to avoid sensor properties losing after resume from S3

Hi All,
	Sorry for the late response, for I am on Qingming Festival for the last 3 days.
I noticed Ritesh has tried a USB sensor, I do not have that kind of sensor at hand and have not tried it yet. My patch worked well for ISH but I am not sure whether it is fine for USB sensor. Sorry for not much information can provide. I will try to see if I can find one device and try.



BR
Song Hongyan

-----Original Message-----
From: Srinivas Pandruvada [mailto:srinivas.pandruvada@...ux.intel.com]
Sent: Wednesday, April 5, 2017 8:45 AM
To: rrs@...earchut.com; Song, Hongyan <hongyan.song@...el.com>; linux-iio <linux-iio@...r.kernel.org>
Cc: stable@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

Hi Ritesh,

Does the attached patch helps?

Thanks,
Srinivas

On Tue, 2017-04-04 at 00:44 +0530, Ritesh Raj Sarraf wrote:
> Adding Stable, LKML and IIO MLs.
> 
> Hello Hongyan,
> 
> Do you have any feedback ? With the bisected commit reverted, I've 
> been successfully running the machine without any issues.
> 
> Ritesh
> 
> 
> On Sat, 2017-04-01 at 08:14 -0700, Srinivas Pandruvada wrote:
> > Hello Hongyan,
> > 
> > Can you check the findings of Ritesh?
> > 
> > Thanks,
> > Srinivas
> > 
> > On Sat, 2017-04-01 at 14:07 +0530, Ritesh Raj Sarraf wrote:
> > > Hello Srinivas,
> > > 
> > > With the Linux 4.10.7 release, I have encountered a regression 
> > > introduced on my Lenovo Yoga 2 13, for the ITE Rotation Sensor.
> > > 
> > > 
> > > rrs@...rner:~$ lsusb
> > > Bus 001 Device 002: ID 8087:8000 Intel Corp. Bus 001 Device 001: 
> > > ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 003 Device 001: ID
> > > 1d6b:0003 Linux Foundation 3.0 root hub Bus 002 Device 006: ID
> > > 048d:8350 Integrated Technology Express, Inc.
> > > Bus 002 Device 005: ID 0bda:b728 Realtek Semiconductor Corp. Bus
> > > 002 Device 004: ID 04f2:b40f Chicony Electronics Co., Ltd Bus 002 
> > > Device 003: ID 04f3:0303 Elan Microelectronics Corp.
> > > Bus 002 Device 002: ID 0bda:0129 Realtek Semiconductor Corp.
> > > RTS5129
> > > Card Reader
> > > Controller
> > > Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > > 2017-04-01 / 14:04:49 ♒♒♒  ☺
> > > 
> > > 
> > > The ITE sensors do not feed any data on the 4.10.7 kernel.
> > > Reverting
> > > back to
> > > 4.10.5, everything works back.
> > > 
> > > 
> > > After a git bisect, the culprit reported is:
> > > 
> > > Bisecting: 0 revisions left to test after this (roughly 0 steps) 
> > > [6c2aab07d12436af1cd8d9ac1d117a442cc91eec] iio: hid-sensor-
> > > trigger:
> > > Change get
> > > poll value function order to avoid sensor properties losing after 
> > > resume from S3
> > > 1
> > > 
> > > Can you please review my findings to confirm that it really is a 
> > > regression bug ?
> > > 
> > > 
> > > Thanks,
> > > Ritesh
> > >