linux-kernel - Re: [PATCH v2 6/9] drm/rockchip: Reoder unload sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58E4C4F2.7090306@rock-chips.com>
Date:   Wed, 05 Apr 2017 18:20:34 +0800
From:   jeffy <jeffy.chen@...k-chips.com>
To:     Sean Paul <seanpaul@...omium.org>
CC:     linux-kernel@...r.kernel.org, briannorris@...omium.org,
        dianders@...omium.org, tfiga@...omium.org, zyw@...k-chips.com,
        mark.yao@...k-chips.com, Heiko Stuebner <heiko@...ech.de>,
        dri-devel@...ts.freedesktop.org,
        linux-rockchip@...ts.infradead.org,
        David Airlie <airlied@...ux.ie>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 6/9] drm/rockchip: Reoder unload sequence

Hi Sean,

On 04/05/2017 03:44 AM, Sean Paul wrote:
> On Sat, Apr 01, 2017 at 07:35:26PM +0800, Jeffy Chen wrote:
>> We should not cleanup iommu before cleanup other resources.
>>
>> Reorder unload sequence, follow exynos drm.
>
> This doesn't match the cleanup sequence in rockchip_drm_bind. Also make sure
> that you're unwinding the setup sequence when you cleanup (ie: take a close look
> at how you set things up and reverse it for cleanup).
ok, will reoder the bind sequence too, thanx.
>
> Sean
>
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
>> ---
>>
>> Changes in v2: None
>>
>>   drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>> index b360e62..a5d83cb 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
>> @@ -244,11 +244,13 @@ static void rockchip_drm_unbind(struct device *dev)
>>   	struct drm_device *drm_dev = dev_get_drvdata(dev);
>>
>>   	rockchip_drm_fbdev_fini(drm_dev);
>> -	drm_vblank_cleanup(drm_dev);
>>   	drm_kms_helper_poll_fini(drm_dev);
>> +
>> +	drm_vblank_cleanup(drm_dev);
>>   	component_unbind_all(dev, drm_dev);
>> -	rockchip_iommu_cleanup(drm_dev);
>>   	drm_mode_config_cleanup(drm_dev);
>> +	rockchip_iommu_cleanup(drm_dev);
>> +
>>   	drm_dev->dev_private = NULL;
>>   	drm_dev_unregister(drm_dev);
>>   	drm_dev_unref(drm_dev);
>> --
>> 2.1.4
>>
>