linux-kernel - Re: [PATCH 16/16] drivers, net, intersil: convert request_context.refcount from atomic_t to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k26zi1p3.fsf@kamboji.qca.qualcomm.com>
Date:   Wed, 05 Apr 2017 13:33:12 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "Reshetova\, Elena" <elena.reshetova@...el.com>
Cc:     "netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel\@lists.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-rdma\@vger.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-hams\@vger.kernel.org" <linux-hams@...r.kernel.org>,
        "linux-ppp\@vger.kernel.org" <linux-ppp@...r.kernel.org>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>,
        "ganeshgr\@chelsio.com" <ganeshgr@...lsio.com>,
        "nbd\@openwrt.org" <nbd@...nwrt.org>,
        "blogic\@openwrt.org" <blogic@...nwrt.org>,
        "matthias.bgg\@gmail.com" <matthias.bgg@...il.com>,
        "yishaih\@mellanox.com" <yishaih@...lanox.com>,
        "saeedm\@mellanox.com" <saeedm@...lanox.com>,
        "matanb\@mellanox.com" <matanb@...lanox.com>,
        "leonro\@mellanox.com" <leonro@...lanox.com>,
        "ajk\@comnets.uni-bremen.de" <ajk@...nets.uni-bremen.de>,
        "paulus\@samba.org" <paulus@...ba.org>, "j\@w1.fi" <j@...fi>,
        "peterz\@infradead.org" <peterz@...radead.org>,
        "keescook\@chromium.org" <keescook@...omium.org>,
        "gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>,
        Hans Liljestrand <ishkamiel@...il.com>,
        David Windsor <dwindsor@...il.com>
Subject: Re: [PATCH 16/16] drivers, net, intersil: convert request_context.refcount from atomic_t to refcount_t

"Reshetova, Elena" <elena.reshetova@...el.com> writes:

>> Elena Reshetova <elena.reshetova@...el.com> writes:
>> 
>> > refcount_t type and corresponding API should be
>> > used instead of atomic_t when the variable is used as
>> > a reference counter. This allows to avoid accidental
>> > refcounter overflows that might lead to use-after-free
>> > situations.
>> >
>> > Signed-off-by: Elena Reshetova <elena.reshetova@...el.com>
>> > Signed-off-by: Hans Liljestrand <ishkamiel@...il.com>
>> > Signed-off-by: Kees Cook <keescook@...omium.org>
>> > Signed-off-by: David Windsor <dwindsor@...il.com>
>> > ---
>> >  drivers/net/wireless/intersil/orinoco/orinoco_usb.c | 15 ++++++++-------
>> >  1 file changed, 8 insertions(+), 7 deletions(-)
>> 
>> The prefix should be "orinoco_usb:", I'll fix that.
>
> Thanks for both! Will you take the patches in?

You mean patches 15 and 16? I didn't even look rest of the patches.

But not sure yet because Dave doesn't seem to like the interface and I
want to follow the discussion first.

-- 
Kalle Valo