linux-kernel - Re: [PATCH v2 2/2] x86/mce/AMD: Carve out SMCA bank configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170405141902.6dnh2gzpt7k35e4l@pd.tnic>
Date:   Wed, 5 Apr 2017 16:19:02 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Yazen Ghannam <Yazen.Ghannam@....com>
Cc:     linux-edac@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] x86/mce/AMD: Carve out SMCA bank configuration

On Tue, Apr 04, 2017 at 12:24:32PM -0500, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@....com>
> 
> Scalable MCA systems have a new MCA_CONFIG register that we use to
> configure each bank. We currently use this when we set up thresholding.
> However, this is logically separate.
> 
> Group all SMCA-related initialization into a single, separate function.
> This includes setting MCA_CONFIG and gathering SMCA bank info.
> 
> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> ---
> Link:
> https://lkml.kernel.org/r/1490210971-62346-2-git-send-email-Yazen.Ghannam@amd.com
> 
> v1->v2:
> - Merge get_smca_bank_info() and set_smca_config() into smca_configure().
> 
>  arch/x86/kernel/cpu/mcheck/mce_amd.c | 74 ++++++++++++++++++------------------
>  1 file changed, 37 insertions(+), 37 deletions(-)

...

> @@ -516,7 +516,7 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c)
>  
>  	for (bank = 0; bank < mca_cfg.banks; ++bank) {
>  		if (mce_flags.smca)
> -			get_smca_bank_info(bank);
> +			smca_configure(bank);

Pass in cpu from above:

			smca_configure(bank, cpu);


>  
>  		for (block = 0; block < NR_BLOCKS; ++block) {
>  			address = get_block_address(cpu, address, low, high, bank, block);
> -- 

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.