linux-kernel - Re: [PATCH 5/6] ASoC: wm8978: Add OF device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170405085154.GY6986@localhost.localdomain>
Date:   Wed, 5 Apr 2017 09:51:54 +0100
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     Javier Martinez Canillas <javier@....samsung.com>
CC:     <linux-kernel@...r.kernel.org>, Jaroslav Kysela <perex@...ex.cz>,
        <alsa-devel@...a-project.org>,
        <patches@...nsource.wolfsonmicro.com>,
        "Mark Brown" <broonie@...nel.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Takashi Iwai <tiwai@...e.com>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        Julia Lawall <Julia.Lawall@...6.fr>
Subject: Re: [PATCH 5/6] ASoC: wm8978: Add OF device ID table

On Tue, Apr 04, 2017 at 03:26:29PM -0400, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
> 
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
> 
> Before this patch:
> 
> $ modinfo sound/soc/codecs/snd-soc-wm8978.ko | grep alias
> alias:          i2c:wm8978
> 
> After this patch:
> 
> $ modinfo sound/soc/codecs/snd-soc-wm8978.ko | grep alias
> alias:          i2c:wm8978
> alias:          of:N*T*Cwlf,wm8978C*
> alias:          of:N*T*Cwlf,wm8978
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>

Thanks,
Charles