linux-kernel - RE: [RFC 4/8] p2pmem: Add debugfs "stats" file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <003201d2ae23$6527ef10$2f77cd30$@opengridcomputing.com>
Date:   Wed, 5 Apr 2017 10:43:38 -0500
From:   "Steve Wise" <swise@...ngridcomputing.com>
To:     "'Sagi Grimberg'" <sagi@...mberg.me>,
        "'Logan Gunthorpe'" <logang@...tatee.com>,
        "'Christoph Hellwig'" <hch@....de>,
        "'James E.J. Bottomley'" <jejb@...ux.vnet.ibm.com>,
        "'Martin K. Petersen'" <martin.petersen@...cle.com>,
        "'Jens Axboe'" <axboe@...nel.dk>,
        "'Stephen Bates'" <sbates@...thlin.com>,
        "'Max Gurtovoy'" <maxg@...lanox.com>,
        "'Dan Williams'" <dan.j.williams@...el.com>,
        "'Keith Busch'" <keith.busch@...el.com>,
        "'Jason Gunthorpe'" <jgunthorpe@...idianresearch.com>
Cc:     <linux-pci@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <linux-nvme@...ts.infradead.org>, <linux-rdma@...r.kernel.org>,
        <linux-nvdimm@...ts.01.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [RFC 4/8] p2pmem: Add debugfs "stats" file

> 
> > +	p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL);
> > +	if (!p2pmem_debugfs_root)
> > +		pr_info("could not create debugfs entry, continuing\n");
> > +
> 
> Why continue? I think it'd be better to just fail it.
> 

Because not having debugfs support isn't fatal to using p2pmem.  So I
believe it is better to continue.  But this is trivial, IMO, so either was
is ok with me.

> Besides, this can be safely squashed into patch 1.

Yes.