linux-kernel - Re: [PATCH v4 4/6] arm64: dts: rockchip: add core dtsi file for RK3328 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58E4516D.4000805@rock-chips.com>
Date:   Wed, 05 Apr 2017 10:07:41 +0800
From:   Elaine Zhang <zhangqing@...k-chips.com>
To:     Heiko Stuebner <heiko@...ech.de>, cl@...k-chips.com
CC:     robh+dt@...nel.org, mark.rutland@....com, zhengxing@...k-chips.com,
        andy.yan@...k-chips.com, jay.xu@...k-chips.com,
        matthias.bgg@...il.com, paweljarosz3691@...il.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        wsa@...-dreams.de, linux-i2c@...r.kernel.org, jic23@...nel.org,
        knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        wxt@...k-chips.com, david.wu@...k-chips.com,
        linux-iio@...r.kernel.org, shawn.lin@...k-chips.com,
        akpm@...ux-foundation.org, dianders@...omium.org,
        yamada.masahiro@...ionext.com, catalin.marinas@....com,
        will.deacon@....com, afaerber@...e.de, shawnguo@...nel.org,
        khilman@...libre.com, arnd@...db.de, fabio.estevam@....com,
        kever.yang@...k-chips.com, tony.xie@...k-chips.com,
        huangtao@...k-chips.com, yhx@...k-chips.com,
        rocky.hao@...k-chips.com
Subject: Re: [PATCH v4 4/6] arm64: dts: rockchip: add core dtsi file for RK3328
 SoCs



On 04/05/2017 12:04 AM, Heiko Stuebner wrote:
> Am Montag, 27. März 2017, 17:40:48 CEST schrieb cl@...k-chips.com:
>> From: Liang Chen <cl@...k-chips.com>
>>
>> This patch adds core dtsi file for Rockchip RK3328 SoCs.
>>
>> Signed-off-by: Liang Chen <cl@...k-chips.com>
>
> applied for 4.12, with the following list of changes:
>
> - reorder some properties to bring them in alphabetical order
> - dropped the status-disabled from the power-controller
>    power-domain control is a quite essential part of the system, so if
>    boards really want to disable them, they should do it in their board file
>    Having power-domains on all the time, is also our default in all other
>    devicetrees.
> - removed #dma-cells from spi0 -> this is not a dma controller
> - reword the cru assigned-clocks comment a bit
> - fixed sdmmc1_bus4 pins, as indicated by Shawn and after looking up the
>    correct pins in the manual
>
>
> And a final question, are you sure about SCLK_PDM becoming a child of the
> APLL in your cru assigned-clocks, as the APLL will vary later on with cpufreq
> active?
>
the NPLL will vary later on with cpufreq active.

The NPLL is better than APLL, so NPLL is for clk_core,and apll is for pdm.

please see the TRM in CRU:
1.4 Function Description
/........./
To maximize the flexibility, some of clocks can select divider source 
from 5 PLLs. (Note: It’s
recommended to use NEW PLL instead of ARM PLL as arm clock source, 
because NEW PLL is
near to ARM. And it’s jitter is better than ARM PLL).

>
> Heiko
>
>
>