linux-kernel - Re: [PATCH] ebpf: verify the output of the JIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201704060114.x8NRcFfZ%fengguang.wu@intel.com>
Date:   Thu, 6 Apr 2017 01:52:10 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Tycho Andersen <tycho@...ker.com>
Cc:     kbuild-all@...org, Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        kernel-hardening@...ts.openwall.com,
        Tycho Andersen <tycho@...ker.com>,
        Mickaël Salaün <mic@...ikod.net>
Subject: Re: [PATCH] ebpf: verify the output of the JIT

Hi Tycho,

[auto build test WARNING on net/master]
[also build test WARNING on v4.11-rc5 next-20170405]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Tycho-Andersen/ebpf-verify-the-output-of-the-JIT/20170406-004746
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   arch/x86/net/bpf_jit_comp.c: In function 'do_jit':
>> arch/x86/net/bpf_jit_comp.c:1098:1: warning: the frame size of 13024 bytes is larger than 8192 bytes [-Wframe-larger-than=]
    }
    ^

vim +1098 arch/x86/net/bpf_jit_comp.c

9383191d Daniel Borkmann    2017-02-16  1082  			pr_err("bpf_jit: fatal insn size error\n");
e0ee9c12 Alexei Starovoitov 2014-10-10  1083  			return -EFAULT;
e0ee9c12 Alexei Starovoitov 2014-10-10  1084  		}
e0ee9c12 Alexei Starovoitov 2014-10-10  1085  
0a14842f Eric Dumazet       2011-04-20  1086  		if (image) {
0a14842f Eric Dumazet       2011-04-20  1087  			if (unlikely(proglen + ilen > oldproglen)) {
9383191d Daniel Borkmann    2017-02-16  1088  				pr_err("bpf_jit: fatal error\n");
f3c2af7b Alexei Starovoitov 2014-05-13  1089  				return -EFAULT;
0a14842f Eric Dumazet       2011-04-20  1090  			}
0a14842f Eric Dumazet       2011-04-20  1091  			memcpy(image + proglen, temp, ilen);
0a14842f Eric Dumazet       2011-04-20  1092  		}
0a14842f Eric Dumazet       2011-04-20  1093  		proglen += ilen;
0a14842f Eric Dumazet       2011-04-20  1094  		addrs[i] = proglen;
0a14842f Eric Dumazet       2011-04-20  1095  		prog = temp;
0a14842f Eric Dumazet       2011-04-20  1096  	}
f3c2af7b Alexei Starovoitov 2014-05-13  1097  	return proglen;
f3c2af7b Alexei Starovoitov 2014-05-13 @1098  }
f3c2af7b Alexei Starovoitov 2014-05-13  1099  
19d23b2d Tycho Andersen     2017-04-04  1100  #ifdef CONFIG_EBPF_JIT_HASH_OUTPUT
19d23b2d Tycho Andersen     2017-04-04  1101  static struct shash_desc *bpf_alloc_hash_desc(void)
19d23b2d Tycho Andersen     2017-04-04  1102  {
19d23b2d Tycho Andersen     2017-04-04  1103  	struct shash_desc *hash;
19d23b2d Tycho Andersen     2017-04-04  1104  	int sz = sizeof(struct shash_desc) + crypto_shash_descsize(tfm);
19d23b2d Tycho Andersen     2017-04-04  1105  
19d23b2d Tycho Andersen     2017-04-04  1106  	hash = kzalloc(sz, GFP_KERNEL);

:::::: The code at line 1098 was first introduced by commit
:::::: f3c2af7ba17a83809806880062c9ad541744fb95 net: filter: x86: split bpf_jit_compile()

:::::: TO: Alexei Starovoitov <ast@...mgrid.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (58846 bytes)