linux-kernel - Re: [PATCH v3 2/9] drm: bridge: analogix: Unregister dp aux when unbinding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <724682a8-e97b-660f-0867-306d068904ff@samsung.com>
Date:   Thu, 06 Apr 2017 09:11:13 +0200
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>,
        linux-kernel@...r.kernel.org
Cc:     Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        briannorris@...omium.org, dianders@...omium.org,
        dri-devel@...ts.freedesktop.org, tfiga@...omium.org,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        zyw@...k-chips.com, Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v3 2/9] drm: bridge: analogix: Unregister dp aux when
 unbinding

On 05.04.2017 10:29, Jeffy Chen wrote:
> The dp aux is registered when binding analogix dp.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>

Btw, if you are working already in this area you can check also to
analogix_dp bind and unbind routines they looks suspiciously asymmetric.
I guess component framework deals correctly with devm_* stuff but I see
for example clk_prepare_enable not paired with clk_unprepare*.

--
Regards
Andrzej
> ---
>
> Changes in v3: None
> Changes in v2: None
>
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 28144a1..7b75f82 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1447,6 +1447,7 @@ void analogix_dp_unbind(struct device *dev, struct device *master,
>  			DRM_ERROR("failed to detach the panel\n");
>  	}
>  
> +	drm_dp_aux_unregister(&dp->aux);
>  	pm_runtime_disable(dev);
>  }
>  EXPORT_SYMBOL_GPL(analogix_dp_unbind);